Add lint to check that EV certificates contain only allowed attributes in the Subject #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added //nolint:all to comment block to avoid golangci-lint to complain about duplicate words in comment
Fixed import block
Fine to me. Co-authored-by: Christopher Henderson <[email protected]>
As per Chris Henderson's suggestion, to "improve readability".
As per Chris Henderson's suggestion.
Added CABFEV_Sec9_2_8_Date
christopher-henderson
approved these changes
Dec 8, 2024
| * attribute and were issued before that date have long since expired, so it makes no difference. | ||
| */ | ||
| var allowedAttribs = map[string]bool{ | ||
| "1.3.6.1.4.1.311.60.2.1.1": true, // joiLocalityName |
There was a problem hiding this comment.
Thank you for taking the time to clearly enumerate these. It must have been at least mildly tedious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that Zlint currently does not check the correct composition of the Subject of EV certificates, so I propose this lint to fill the gap. This lint verifies that the subject of an EV certificate does not contain other attributes than those expressly allowed in the EV Guidelines (requirement introduced by the SC16 ballot which came into force on 16 April 2019).